Allow writing on-request minidumps with an exception stream on OS X

This patch builds on top of the patch from issue 165001. The APIs added here are
also added in those Windows/Linux patches that I haven't finished upstreaming.

[Ted Mielczarek]

Looks like I also failed to send mail for this issue. *sigh*

[Mark Mentovai]

LGO

http://breakpad.appspot.com/172001/diff/1/2
File src/client/mac/handler/exception_handler.cc (right):

http://breakpad.appspot.com/172001/diff/1/2#newcode56
Line 56: // Message ID telling the handler thread to write a dump.
Why did you pick such a weird order to put these messages in?

Can you use an enum instead of having three distinct constants?

http://breakpad.appspot.com/172001/diff/1/2#newcode293
Line 293: kWriteDumpWithExceptionMessage
Style nit: indent this line by 4 more spaces, put the : on this line, and line
up kWriteDumpMessage with kWriteDumpWithExceptionMessage.

http://breakpad.appspot.com/172001/diff/1/2#newcode560
Line 560: #error architecture not supported
Don’t indent preprocessor things.

http://breakpad.appspot.com/172001/diff/1/3
File src/client/mac/handler/exception_handler.h (right):

http://breakpad.appspot.com/172001/diff/1/3#newcode169
Line 169: int exception_subcode, mach_port_t thread_name,
Busted the 80 character limit.

[Ted Mielczarek]

http://breakpad.appspot.com/172001/diff/1/2
File src/client/mac/handler/exception_handler.cc (right):

http://breakpad.appspot.com/172001/diff/1/2#newcode56
Line 56: // Message ID telling the handler thread to write a dump.
On 2010/12/08 20:57:19, Mark Mentovai wrote:
> Why did you pick such a weird order to put these messages in?

I think in the previous patch it was an artifact of the zeroed-out message
originally meaning "write a dump", and then I added "quit" as 1, so I guess I
just added the new message to the end instead of reordering. I'll reorder them
more sensibly.

> Can you use an enum instead of having three distinct constants?

Yeah, although it always bums me out to not be able to use the strictly correct
typedef when using enums like that.