Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(772)

Issue 163001: Put PUBLIC lines in Mac and Linux symbol files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Mark Mentovai
Modified:
12 years, 7 months ago
Reviewers:
jimb, Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Put PUBLIC lines in Mac and Linux symbol files.

BUG=397

Landed elsewhere

Patch Set 1 #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/module.cc View 3 chunks +24 lines, -0 lines 2 comments Download
M src/common/module.h View 6 chunks +28 lines, -0 lines 4 comments Download
M src/common/stabs_reader.cc View 2 chunks +21 lines, -1 line 2 comments Download
M src/common/stabs_reader.h View 2 chunks +8 lines, -0 lines 2 comments Download
M src/common/stabs_to_module.cc View 1 chunk +11 lines, -0 lines 1 comment Download
M src/common/stabs_to_module.h View 4 chunks +7 lines, -6 lines 1 comment Download

Messages

Total messages: 9
jimb
I'm sorry about missing this --- I had it on a "to-do" list that got ...
13 years, 7 months ago #1
Ted Mielczarek
http://breakpad.appspot.com/163001/diff/1/2 File src/common/module.cc (right): http://breakpad.appspot.com/163001/diff/1/2#newcode257 Line 257: last_address = ext->address; Not terribly important, but could ...
13 years, 7 months ago #2
jimb
http://breakpad.appspot.com/163001/diff/1/2 File src/common/module.cc (right): http://breakpad.appspot.com/163001/diff/1/2#newcode257 Line 257: last_address = ext->address; Yeah, I agree; let's write ...
13 years, 7 months ago #3
jimb
Hi, Mark. Any progress on getting this revised and in upstream?
13 years, 6 months ago #4
Mark Mentovai
I just noticed this again yesterday. I hope to have time next week.
13 years, 6 months ago #5
Ted Mielczarek
On 2010/10/01 19:42:49, Mark Mentovai wrote: > I just noticed this again yesterday. I hope ...
13 years, 1 month ago #6
Mark Mentovai
Yes, it’d be helpful if you could integrate the review comments. I can review (or ...
13 years, 1 month ago #7
Ted Mielczarek
On 2011/02/22 19:35:48, Mark Mentovai wrote: > Yes, it’d be helpful if you could integrate ...
13 years, 1 month ago #8
Ted Mielczarek
12 years, 9 months ago #9
FYI, this patch landed, and I have a patch hanging out to implement this for
Linux here:
http://breakpad.appspot.com/275001/show
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted