Issue 152001: Miscellaneous improvements to minidump-2-core....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 152001: Miscellaneous improvements to minidump-2-core.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by Lei Zhang (chromium)

Modified:
14 years, 2 months ago

Reviewers:
markus

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Miscellaneous improvements to minidump-2-core.

Patch by Markus Gutschke <markus@chromium.org>.  R=agl
See http://breakpad.appspot.com/148002 and
http://codereview.chromium.org/3152010.

Committed: http://code.google.com/p/google-breakpad/source/detail?r=648

Patch Set 1 #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	A	src/client/linux/minidump_writer/minidump_extension_linux.h	View		1 chunk	+74 lines, -0 lines	0 comments	Download
	M	src/tools/linux/md2core/minidump-2-core.cc	View		19 chunks	+661 lines, -72 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Lei Zhang (chromium)

I fixed some lint issues, please take a look and I'll commit it for you.

14 years, 2 months ago #1

LGTM

Expand All Messages | Collapse All Messages