Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(278)

Issue 151001: Put MachIPC into the google_breakpad namespace (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by Ted Mielczarek
Modified:
15 years ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Kind of lame, but we wound up with two copies of this in the Mozilla tree since
we have the Chromium IPC code as well. Seems sensible to have this in a
namespace.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/Framework/Breakpad.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M src/client/mac/tests/exception_handler_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/common/mac/MachIPC.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/common/mac/MachIPC.mm View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Ted Mielczarek
15 years ago #1
Mark Mentovai
15 years ago #2
OK, LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted