Issue 151001: Put MachIPC into the google_breakpad namespace

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 151001: Put MachIPC into the google_breakpad namespace (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by Ted Mielczarek

Modified:
13 years, 8 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

Kind of lame, but we wound up with two copies of this in the Mozilla tree since
we have the Chromium IPC code as well. Seems sensible to have this in a
namespace.

Patch Set 1 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/mac/Framework/Breakpad.mm	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/client/mac/tests/exception_handler_test.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/common/mac/MachIPC.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/common/mac/MachIPC.mm	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

OK, LGTM

Expand All Messages | Collapse All Messages