Issue 15002: OS X exception handler / minidump generator should set exception address correctly for EXC_BAD_ACCES

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 15002: OS X exception handler / minidump generator should set exception address correctly for EXC_BAD_ACCES (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by Ted Mielczarek

Modified:
15 years, 4 months ago

Reviewers:
mochalatte

CC:
google-breakpad-dev_googlegroups.com

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Copied over from http://code.google.com/p/google-breakpad/issues/detail?id=323.
Neal, can you take a look?

Patch Set 1 #

Total comments: 1

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats			Patch
src/client/mac/Framework/Breakpad.mm	View	5 chunks	+7 lines, -1 line	0 comments	Download
src/client/mac/crash_generation/Inspector.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
src/client/mac/crash_generation/Inspector.mm	View	3 chunks	+3 lines, -0 lines	0 comments	Download
src/client/mac/handler/exception_handler.cc	View	5 chunks	+13 lines, -6 lines	1 comment	Download
src/client/mac/handler/exception_handler.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
src/client/mac/handler/exception_handler_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
src/client/mac/handler/minidump_generator.cc	View	3 chunks	+6 lines, -1 line	0 comments	Download
src/client/mac/handler/minidump_generator.h	View	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM, with one nit
Thanks for finding & fixing this, and I guess you'll have to do a small merge
after my checkin this morning :-)

http://breakpad.appspot.com/15002/diff/1/4
File src/client/mac/handler/exception_handler.cc (right):

http://breakpad.appspot.com/15002/diff/1/4#newcode326
Line 326: thread_name);
80-cols

Expand All Messages | Collapse All Messages