Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(710)

Issue 148001: Support generating minidumps from live processes on OS X (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by Ted Mielczarek
Modified:
13 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

This patch implements ExceptionHandler::WriteMinidumpForChild, the same API
provided by the patches in:
http://breakpad.appspot.com/115002/show
http://breakpad.appspot.com/123001/show

Those have yet to land in the Breakpad repo, but I think it's useful API.

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/client/mac/Breakpad.xcodeproj/project.pbxproj View 1 chunk +1 line, -1 line 0 comments Download
M src/client/mac/handler/exception_handler.cc View 1 chunk +33 lines, -0 lines 2 comments Download
M src/client/mac/handler/exception_handler.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/client/mac/handler/minidump_generator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M src/client/mac/tests/exception_handler_test.cc View 3 chunks +80 lines, -1 line 7 comments Download

Messages

Total messages: 3
Ted Mielczarek
13 years, 8 months ago #1
Mark Mentovai
lgo http://breakpad.appspot.com/148001/diff/1/3 File src/client/mac/handler/exception_handler.cc (right): http://breakpad.appspot.com/148001/diff/1/3#newcode332 Line 332: if (task_suspend(child) != KERN_SUCCESS) ScopedTaskSuspend would be ...
13 years, 8 months ago #2
Ted Mielczarek
13 years, 8 months ago #3
http://breakpad.appspot.com/148001/diff/1/3
File src/client/mac/handler/exception_handler.cc (right):

http://breakpad.appspot.com/148001/diff/1/3#newcode332
Line 332: if (task_suspend(child) != KERN_SUCCESS)
On 2010/08/13 16:59:42, Mark Mentovai wrote:
> ScopedTaskSuspend would be helpful here too.

Is this something that's already written, or are you suggesting I write it?

http://breakpad.appspot.com/148001/diff/1/6
File src/client/mac/tests/exception_handler_test.cc (right):

http://breakpad.appspot.com/148001/diff/1/6#newcode145
Line 145: (void)read(fds[1], &data, 1);
On 2010/08/13 16:59:42, Mark Mentovai wrote:
> (void) not helpful.

Depending on the compiler, I've had compile errors telling me I'm not allowed to
ignore the return value. Doesn't seem to be the case here.

http://breakpad.appspot.com/148001/diff/1/6#newcode180
Line 180: sleep(10000);
On 2010/08/13 16:59:42, Mark Mentovai wrote:
> What’s this about?

Oops, I stuck that in there so I could easily look at the resulting dump, and
forgot to remove it. (Then spent 5 minutes this morning trying to figure out why
my test was hanging.)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted