Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 143001: Breakpad uses x86 as the architecture name, not i386 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 3 months ago by Mark Mentovai
Modified:
14 years, 3 months ago
Reviewers:
mochalatte
CC:
google-breakpad-dev_googlegroups.com
Base URL:
http://google-breakpad.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Breakpad uses x86 as the architecture name, not i386. Most tools don't care
what architecture name is shown in a symbol file's MODULE line, but the Mac
crash_report tool's on_demand_symbol_supplier does. The new Mac dumper
inadvertently used i386. Correct that to make it x86. Temporarily make the
on_demand_symbol_supplier accept symbol files whose architecture is i386.
Also add x86_64 to the set of architectures that the on_demand_symbol_supplier
considers valid.

BUG=none
TEST=none

Committed: http://code.google.com/p/google-breakpad/source/detail?r=638

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/mac/dump_syms.mm View 2 chunks +6 lines, -2 lines 0 comments Download
M src/tools/mac/crash_report/on_demand_symbol_supplier.mm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Mark Mentovai
Neal, I’ll check this in as-is and then immediately check in a followup to remove ...
14 years, 3 months ago #1
mochalatte
14 years, 3 months ago #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted