Issue 138001: More Mac project cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 138001: More Mac project cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by dmaclach

Modified:
14 years, 1 month ago

Reviewers:
Mark Mentovai, mochalatte

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Fixing Mark's issues (with the code) #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/client/mac/Breakpad.xcodeproj/project.pbxproj	View	1	26 chunks	+34 lines, -66 lines	0 comments	Download
M	src/client/mac/testapp/Controller.m	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/common/test_assembler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/tools/mac/crash_report/crash_report.xcodeproj/project.pbxproj	View	1	6 chunks	+7 lines, -7 lines	0 comments	Download
M	src/tools/mac/dump_syms/dump_syms.xcodeproj/project.pbxproj	View		32 chunks	+187 lines, -7 lines	0 comments	Download
M	src/tools/mac/symupload/symupload.xcodeproj/project.pbxproj	View	1	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dmaclach

Cleans up projects so that frameworks and libraries are SDK relative as opposed to being ...

14 years, 2 months ago #1

Mark Mentovai

LG otherwise. I love SDKROOT. http://breakpad.appspot.com/138001/diff/1/7 File src/client/mac/Breakpad.xcodeproj/project.pbxproj (right): http://breakpad.appspot.com/138001/diff/1/7#newcode1667 Line 1667: HEADER_SEARCH_PATHS = ../../; ...

14 years, 2 months ago #2

Mark Mentovai

14 years, 2 months ago #3

http://breakpad.appspot.com/138001/diff/1/7
File src/client/mac/Breakpad.xcodeproj/project.pbxproj (right):

http://breakpad.appspot.com/138001/diff/1/7#newcode1783
Line 1783: USER_HEADER_SEARCH_PATHS = ../../;
I wrote:
> USER_HEADER_SEARCH_PATHS instead of plain ol’ HEADER_SEARCH_PATHS? Throughout.

Clarification:

Plain ol’ HEADER_SEARCH_PATHS is fine, and it’s all I usually use. I was
wondering why most of this project seemed to use it, and then you switched to
USER_HEADER_SEARCH_PATHS here.

Expand All Messages | Collapse All Messages