Continued Cleanup

[dmaclach]

Cleans up the dump_syms project so that it compiles faster.
Cleans up the documentation in Breakpad.h to reflect reality.
Changes display name so that it picks up CFBundleDisplayName first, and then
falls back on CFBundleName.

[Mark Mentovai]

http://breakpad.appspot.com/137001/diff/1/3
File src/client/mac/Framework/Breakpad.h (right):

http://breakpad.appspot.com/137001/diff/1/3#newcode114
Line 114: //                                CFBundleName from Info.plist if not
Your new text isn’t true.

This doesn’t check Info.plist, it checks |parameters|. Same on lines 121 and
126.

|parameters| may be the contents of Info.plist, but it doesn’t need to be.

http://breakpad.appspot.com/137001/diff/1/4
File src/client/mac/Framework/Breakpad.mm (right):

http://breakpad.appspot.com/137001/diff/1/4#newcode293
Line 293: = [filemgr stringWithFileSystemRepresentation:info.dli_fname
Since you’re touching this, you should also fix it to use the correct convention
of indenting four spaces on a continuation line.

Same at line 414.

http://breakpad.appspot.com/137001/diff/1/2
File src/tools/mac/dump_syms/dump_syms.xcodeproj/project.pbxproj (right):

http://breakpad.appspot.com/137001/diff/1/2#newcode1213
Line 1213: HEADER_SEARCH_PATHS = ../../..;
Thank you. I hate **.

[dmaclach]

New version up with fixes.

[Mark Mentovai]

LG™

http://breakpad.appspot.com/137001/diff/9001/10003
File src/client/mac/Framework/Breakpad.mm (right):

http://breakpad.appspot.com/137001/diff/9001/10003#newcode292
Line 292: NSString *filePath =
Look at that, you even moved the = to where I like it!