Issue 136001: More code clean up

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 136001: More code clean up (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by dmaclach

Modified:
14 years, 3 months ago

Reviewers:
Mark Mentovai, mochalatte

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/client/mac/handler/dynamic_images.h	View	2 chunks	+7 lines, -7 lines	0 comments	Download
M	src/client/mac/handler/exception_handler.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/client/mac/handler/minidump_generator.cc	View	6 chunks	+10 lines, -7 lines	1 comment	Download
M	src/client/mac/handler/minidump_test.xcodeproj/project.pbxproj	View	20 chunks	+54 lines, -183 lines	0 comments	Download
M	src/common/mac/macho_walker.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Mark Mentovai

14 years, 4 months ago #2

Go go gadget dmac!

LGTM

http://breakpad.appspot.com/136001/diff/1/5
File src/client/mac/handler/minidump_generator.cc (right):

http://breakpad.appspot.com/136001/diff/1/5#newcode957
Line 957: u_int mibsize = static_cast<u_int>(sizeof(mib) / sizeof(mib[0]));
I was surprised to see you using u_int instead of unsigned int (or something
else like size_t), but sure enough, the man page and header both use the u_int
typedef. Go figure.

Expand All Messages | Collapse All Messages