Issue 131001: Breakpad Linux/Mac symbol dumper: Share duplicate strings that arise in DWARF data.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 131001: Breakpad Linux/Mac symbol dumper: Share duplicate strings that arise in DWARF data. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by jimb

Modified:
13 years, 9 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

This patch avoids allocating many copies of identical strings appearing in
debugging information. Without this patch, running dump_syms on Mozilla's
libxul.so (with 173MiB of debugging information) has a peak resident set of
around 450MiB. With this patch, the peak is around 365MiB.

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats			Patch
M	src/common/dwarf_cfi_to_module.cc	View	1 chunk	+14 lines, -5 lines	0 comments	Download
M	src/common/dwarf_cfi_to_module.h	View	3 chunks	+22 lines, -1 line	0 comments	Download
M	src/common/dwarf_cu_to_module.cc	View	3 chunks	+26 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jimb

We're running into problems on some underpowered build machines due to dump_syms's memory consumption. This ...

13 years, 9 months ago #1

Committed, r626.

Expand All Messages | Collapse All Messages