Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8684)

Issue 121002: Allow passing certificate path to HTTPUpload::SendRequest (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by Ted Mielczarek
Modified:
13 years, 7 months ago
CC:
google-breakpad-dev_googlegroups.com
Visibility:
Public.

Description

Cleaning out the couple of local patches that have accumulated downstream in the
Mozilla tree. This is a pretty simple one, and I think we're the only ones using
HTTPUpload anyway. Neal, can you take a look?

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
M src/common/linux/http_upload.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/common/linux/http_upload.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5
Ted Mielczarek
Rietveld doesn't send mail if I just Edit Issue...
13 years, 9 months ago #1
mochalatte
On 2010/06/29 19:19:44, Ted Mielczarek wrote: > Rietveld doesn't send mail if I just Edit ...
13 years, 8 months ago #2
Lei Zhang (chromium)
Nope, it's also used in src/tools/linux/symupload/sym_upload.cc and src/common/linux/http_upload.cc. Care to do a quick fix? I'll ...
13 years, 7 months ago #3
Ted Mielczarek
On 2010/08/18 08:36:19, thestig wrote: > Nope, it's also used in src/tools/linux/symupload/sym_upload.cc and > src/common/linux/http_upload.cc. ...
13 years, 7 months ago #4
Lei Zhang (chromium)
13 years, 7 months ago #5
On 2010/08/18 12:25:45, Ted Mielczarek wrote:
> On 2010/08/18 08:36:19, thestig wrote:
> > Nope, it's also used in src/tools/linux/symupload/sym_upload.cc and
> > src/common/linux/http_upload.cc. Care to do a quick fix? I'll review in the
> > morning.
> 
> I pushed a trivial fix in r657 if you'd like to give it a once-over. Sorry
about
> that!

I can't find the review URL, but the patch LGTM. Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1004:630ec63f810e-tainted