Issue 121002: Allow passing certificate path to HTTPUpload::SendRequest

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 121002: Allow passing certificate path to HTTPUpload::SendRequest (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by Ted Mielczarek

Modified:
14 years, 3 months ago

Reviewers:
mochalatte, Lei Zhang (chromium)

CC:
google-breakpad-dev_googlegroups.com

Visibility:
Public.

Description

Cleaning out the couple of local patches that have accumulated downstream in the
Mozilla tree. This is a pretty simple one, and I think we're the only ones using
HTTPUpload anyway. Neal, can you take a look?

Patch Set 1 #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
	M	src/common/linux/http_upload.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	src/common/linux/http_upload.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mochalatte

On 2010/06/29 19:19:44, Ted Mielczarek wrote: > Rietveld doesn't send mail if I just Edit ...

14 years, 4 months ago #2

Lei Zhang (chromium)

Nope, it's also used in src/tools/linux/symupload/sym_upload.cc and src/common/linux/http_upload.cc. Care to do a quick fix? I'll ...

14 years, 3 months ago #3

Ted Mielczarek

On 2010/08/18 08:36:19, thestig wrote: > Nope, it's also used in src/tools/linux/symupload/sym_upload.cc and > src/common/linux/http_upload.cc. ...

14 years, 3 months ago #4

Lei Zhang (chromium)

14 years, 3 months ago #5

On 2010/08/18 12:25:45, Ted Mielczarek wrote:
> On 2010/08/18 08:36:19, thestig wrote:
> > Nope, it's also used in src/tools/linux/symupload/sym_upload.cc and
> > src/common/linux/http_upload.cc. Care to do a quick fix? I'll review in the
> > morning.
> 
> I pushed a trivial fix in r657 if you'd like to give it a once-over. Sorry
about
> that!

I can't find the review URL, but the patch LGTM. Thanks!

Expand All Messages | Collapse All Messages