Fix several build breaks with GCC 4.4.1

[zhurunz]

Fix several build breaks with GCC 4.4.1

(I need the changes for ChromeOS Gentoo ebuild.)

[mochalatte]

http://breakpad.appspot.com/100001/diff/1/3
File client/minidump_file_writer.cc (right):

http://breakpad.appspot.com/100001/diff/1/3#newcode78
Line 78: #endif
i think you will overwrite a 'false' value of result here, if the ftruncate
fials and the close succeeds.  perhaps just return early if ftruncate fails?

http://breakpad.appspot.com/100001/diff/1/2
File common/linux/libcurl_wrapper.cc (right):

http://breakpad.appspot.com/100001/diff/1/2#newcode131
Line 131: easy_strerror_ = reinterpret_cast<const char*
(*)(CURLcode)>(dlsym(curl_lib_, "curl_easy_strerror"));
please check the 80 column limit in this file.

[zhurunz]

Done.

http://breakpad.appspot.com/100001/diff/1/3
File client/minidump_file_writer.cc (right):

http://breakpad.appspot.com/100001/diff/1/3#newcode78
Line 78: #endif
On 2010/04/26 22:42:25, mochalatte wrote:
> i think you will overwrite a 'false' value of result here, if the ftruncate
> fials and the close succeeds.  perhaps just return early if ftruncate fails?
> 
OK.
Done.

http://breakpad.appspot.com/100001/diff/1/2
File common/linux/libcurl_wrapper.cc (right):

http://breakpad.appspot.com/100001/diff/1/2#newcode131
Line 131: easy_strerror_ = reinterpret_cast<const char*
(*)(CURLcode)>(dlsym(curl_lib_, "curl_easy_strerror"));
On 2010/04/26 22:42:25, mochalatte wrote:
> please check the 80 column limit in this file.

Done.

[zhurunz]

On 2010/04/26 22:56:15, zhurunz wrote:
> Done.
> 
> http://breakpad.appspot.com/100001/diff/1/3
> File client/minidump_file_writer.cc (right):
> 
> http://breakpad.appspot.com/100001/diff/1/3#newcode78
> Line 78: #endif
> On 2010/04/26 22:42:25, mochalatte wrote:
> > i think you will overwrite a 'false' value of result here, if the ftruncate
> > fials and the close succeeds.  perhaps just return early if ftruncate fails?
> > 
> OK.
> Done.
> 
> http://breakpad.appspot.com/100001/diff/1/2
> File common/linux/libcurl_wrapper.cc (right):
> 
> http://breakpad.appspot.com/100001/diff/1/2#newcode131
> Line 131: easy_strerror_ = reinterpret_cast<const char*
> (*)(CURLcode)>(dlsym(curl_lib_, "curl_easy_strerror"));
> On 2010/04/26 22:42:25, mochalatte wrote:
> > please check the 80 column limit in this file.
> 
> Done.

All Done.

[mochalatte]

thanks for the patch !just one more nit pick, then i think it should be fine.

http://breakpad.appspot.com/100001/diff/7001/8001
File common/linux/libcurl_wrapper.cc (right):

http://breakpad.appspot.com/100001/diff/7001/8001#newcode199
Line 199: 
please chekc for Google C++ style guide violations (in particular, spacing after
commas)

[zhurunz]

Good catch.
Done.

http://breakpad.appspot.com/100001/diff/7001/8001
File common/linux/libcurl_wrapper.cc (right):

http://breakpad.appspot.com/100001/diff/7001/8001#newcode199
Line 199: 
On 2010/04/26 23:06:31, mochalatte wrote:
> please chekc for Google C++ style guide violations (in particular, spacing
after
> commas)
> 

Done.

[mochalatte]

LGTM